[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tools: build golang tools if go compiler is present

On Thu, Apr 23, 2020 at 11:25 AM Wei Liu <wl@xxxxxxx> wrote:
On Wed, Apr 22, 2020 at 08:25:25PM -0400, Nick Rosbrook wrote:
> By default, if the go compiler is found by the configure script, build
> the golang tools. If the compiler is not found, and
> --enable-golang_tools was not explicitly set, do not build to the golang

--enable-golang-tools here.

> tools.
> The new corresponding make variable is CONFIG_GOLANG_TOOLS. Remove
> CONFIG_GOLANG from tools/Rules.mk since the new variable is set by
> configure.
> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>

Acked-by: Wei Liu <wl@xxxxxxx>

Note to self: fix commit message and maybe rerun autogen.sh.

It doesn't look like that's a typo -- if you want it to be `-` instead of `_`, the patch needs to be changed (at least as far as I can tell w/ my admittedly limited automake-foo).




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.