[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table


On 17/04/2020 10:52, Hongyan Xia wrote:> diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c> index e85ef449f3..18210405f4 100644> --- a/xen/arch/x86/x86_64/mm.c> +++ b/xen/arch/x86/x86_64/mm.c> @@ -737,8 +737,8 @@ static void cleanup_frame_table(struct mem_hotadd_info *info)> > while (sva < eva)> {> - l3e = l4e_to_l3e(idle_pg_table[l4_table_offset(sva)])[> - l3_table_offset(sva)];> + l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(sva)],> + l3_table_offset(sva)); This macro doesn't exist yet in the tree. It would be good to spell out the dependencies in the cover letter so this doesn't get merged before the dependency is merged.

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.