[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table

On 24/04/2020 10:21, Hongyan Xia wrote:
Hi Julien,

On Fri, 2020-04-24 at 09:59 +0100, Julien Grall wrote:

On 17/04/2020 10:52, Hongyan Xia wrote:
From: Wei Liu <wei.liu2@xxxxxxxxxx>

Also fix a weird indentation.

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Signed-off-by: Hongyan Xia <hongyxia@xxxxxxxxxx>
   xen/arch/x86/x86_64/mm.c | 14 +++++++-------
   1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index e85ef449f3..18210405f4 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -737,8 +737,8 @@ static void cleanup_frame_table(struct
mem_hotadd_info *info)
while (sva < eva)
-        l3e = l4e_to_l3e(idle_pg_table[l4_table_offset(sva)])[
-          l3_table_offset(sva)];
+        l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(sva)],
+                           l3_table_offset(sva));

This macro doesn't exist yet in the tree. It would be good to spell
the dependencies in the cover letter so this doesn't get merged
the dependency is merged.

I believe the introduction of the new macros has been merged in staging
as 6c8afe5aadb33761431b24157d99b25eac15fc7e.

Hmmmm you are right. I must have been blind. Sorry for the noise.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.