[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v5 04/16] xen/build: have the root Makefile generates the CFLAGS
On 24.04.2020 11:45, Anthony PERARD wrote: > On Thu, Apr 23, 2020 at 06:40:33PM +0200, Jan Beulich wrote: >> On 21.04.2020 18:11, Anthony PERARD wrote: >>> --- a/xen/arch/x86/Rules.mk >>> +++ b/xen/arch/x86/Rules.mk > [..] >>> +c_flags += $(object_label_flags) $(CFLAGS-stack-boundary) >>> +a_flags += $(object_label_flags) $(CFLAGS-stack-boundary) >> >> Why are you also adding these to a_flags? It probably doesn't hurt, >> but I'd prefer if it was removed (could be done while committing if >> all acks arrive and other other need for av6 arises) if there's no >> clear need. > > Those flags are already in a_flags (or previously AFLAGS). I've tried to > be careful to avoid changing the list of *flags in an already > complicated enough patch. I would like to keep this patch that way. > > If the -D__OBJECT_LABEL__ and the stack-bondary flags aren't needed in > a_flags, it would be better to remove them in a separated patch, with > some explanation on why they are removed. Ah, fair point - previously we had # Most CFLAGS are safe for assembly files: # -std=gnu{89,99} gets confused by #-prefixed end-of-line comments # -flto makes no sense and annoys clang AFLAGS += $(filter-out -std=gnu% -flto,$(CFLAGS)) and hence implicitly inherited all kinds of inapplicable flags. I'm fine with this (and probably other things) getting taken care of later then. > What is av6? I was missing a blank: "a v6". Also s/other other/no other". Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |