[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

On 28.04.2020 13:58, vrd@xxxxxxxxxx wrote:
> On 3/10/20 3:19 PM, Jan Beulich wrote:
>> On 09.03.2020 18:47, Paul Durrant wrote:
>>> Please suggest code if you think it ought to be done differentely. I tried.
>> How about this? It's admittedly more code, but imo less ad hoc.
>> I've smoke tested it, but I depend on you or Varad to check that
>> it actually addresses the reported issue.
>> Jan
>> x86/pass-through: avoid double IRQ unbind during domain cleanup
> I have tested that this patch prevents __pirq_guest_unbind on an 
> already-unbound pirq
> during the continuation call for domain_kill -ERESTART, by using a modified 
> xen that
> forces an -ERESTART from pirq_guest_unbind to create the continuation. It 
> fixes the
> underlying issue.
> Tested-by: Varad Gautam <vrd@xxxxxxxxx>

Thanks much; I'll formally submit the patch then.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.