RE: [PATCH 1/2] Fix undefined behaviour

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Paul Durrant <xadimgnik@xxxxxxxxx>
> Sent: 28 April 2020 13:33
> To: 'Artur Puzio' <artur@xxxxxxxxxxxx>; 'Grzegorz Uriasz' 
> <gorbak25@xxxxxxxxx>; qemu-devel@xxxxxxxxxx
> Cc: marmarek@xxxxxxxxxxxxxxxxxxxxxx; jakub@xxxxxxxxxxx; 
> j.nowak26@xxxxxxxxxxxxxxxxx; 'Stefano
> Stabellini' <sstabellini@xxxxxxxxxx>; 'Anthony Perard' 
> <anthony.perard@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: RE: [PATCH 1/2] Fix undefined behaviour
> 
> > -----Original Message-----
> > From: Artur Puzio <artur@xxxxxxxxxxxx>
> > Sent: 28 April 2020 10:41
> > To: paul@xxxxxxx; 'Grzegorz Uriasz' <gorbak25@xxxxxxxxx>; 
> > qemu-devel@xxxxxxxxxx
> > Cc: marmarek@xxxxxxxxxxxxxxxxxxxxxx; jakub@xxxxxxxxxxx; 
> > j.nowak26@xxxxxxxxxxxxxxxxx; 'Stefano
> > Stabellini' <sstabellini@xxxxxxxxxx>; 'Anthony Perard' 
> > <anthony.perard@xxxxxxxxxx>; xen-
> > devel@xxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH 1/2] Fix undefined behaviour
> >
> > On 28.04.2020 10:10, Paul Durrant wrote:
> > >> -----Original Message-----
> > >> From: Grzegorz Uriasz <gorbak25@xxxxxxxxx>
> > >> Sent: 28 April 2020 07:29
> > >> To: qemu-devel@xxxxxxxxxx
> > >> Cc: Grzegorz Uriasz <gorbak25@xxxxxxxxx>; 
> > >> marmarek@xxxxxxxxxxxxxxxxxxxxxx; artur@xxxxxxxxxxxx;
> > >> jakub@xxxxxxxxxxx; j.nowak26@xxxxxxxxxxxxxxxxx; Stefano Stabellini 
> > >> <sstabellini@xxxxxxxxxx>;
> > Anthony
> > >> Perard <anthony.perard@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; 
> > >> xen-devel@xxxxxxxxxxxxxxxxxxxx
> > >> Subject: [PATCH 1/2] Fix undefined behaviour
> > >>
> > >> Signed-off-by: Grzegorz Uriasz <gorbak25@xxxxxxxxx>
> > > I think we need more of a commit comment for both this and patch #2 to 
> > > explain why you are making
> > the changes.
> > >
> > >   Paul
> >
> > I agree Grzegorz should improve the commit messages. In the mean time
> > see email with subject "[PATCH 0/2] Fix QEMU crashes when passing IGD to
> > a guest VM under XEN", it contains quite detailed explanation for both
> > "Fix undefined behaviour" and "Improve legacy vbios handling" patches.
> >
> 
> Ok. Can you please make sure maintainers are cc-ed on patch #0 too.
> 

Actually they are, sorry. My MUA is playing tricks on me.

  Paul