[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v5 13/16] xen,symbols: rework file symbols selection
On 21.04.2020 18:12, Anthony PERARD wrote: > We want to use the same rune to build mm/*/guest_*.o as the one use to > build every other *.o object. The consequence it that file symbols that > the program ./symbols prefer changes with CONFIG_ENFORCE_UNIQUE_SYMBOLS=y. > > For example, when building arch/x86/mm/guest_walk_2.o from guest_walk.c, > this would be the difference of file symbol present in the object when > building with CONFIG_ENFORCE_UNIQUE_SYMBOLS=y: > > (1) Currently we have those two file symbols: > guest_walk.c > guest_walk_2.o > (2) When building with the same rune, we will have: > arch/x86/mm/guest_walk.c > guest_walk_2.o So I had to go to the v4 discussion to understand this again. As said there, it may be obvious to you but despite having been the one to introduce the objcopy step there, it is not to me. Hence my continued desire to have this at least briefly mentioned here, as it's not otherwise noticeable from looking at the patch itself. The code change itself looks okay to me, but I'll want to ack this change only once I can follow the description from a single pass of reading through it. I'm sorry for the extra trouble. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |