[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 04/12] xen: split alloc_heap_pages in two halves for reusability
On Fri, 17 Apr 2020, Jan Beulich wrote: > On 15.04.2020 03:02, Stefano Stabellini wrote: > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -911,54 +911,18 @@ static struct page_info *get_free_buddy(unsigned int > > zone_lo, > > } > > } > > > > -/* Allocate 2^@order contiguous pages. */ > > -static struct page_info *alloc_heap_pages( > > - unsigned int zone_lo, unsigned int zone_hi, > > - unsigned int order, unsigned int memflags, > > - struct domain *d) > > +static void __alloc_heap_pages(struct page_info **pgo, > > + unsigned int order, > > + unsigned int memflags, > > + struct domain *d) > > Along the line of Wei's reply, I'd suggest the name to better reflect > the difference to alloc_heap_pages() itself. Maybe > alloc_pages_from_buddy() or alloc_buddy_pages()? > > In addition > - no double leading underscores please > - instead of the function returning void and taking > struct page_info **pgo, why not have it take and return > struct page_info *? > - add a comment about the non-standard locking behavior I made all these changes
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |