Re: [PATCH 1/2] xen/Kconfig: define EXPERT a bool rather than a string

[Jan Beulich <jbeulich@xxxxxxxx>]

On 30.04.2020 14:43, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Since commit f80fe2b34f08 "xen: Update Kconfig to Linux v5.4" EXPERT
> can only have two values (enabled or disabled). So switch from a string
> to a bool.
> 
> Take the opportunity to replace all "EXPERT = y" to "EXPERT".
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with a remark:

> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -33,7 +33,7 @@ source "arch/Kconfig"
>  
>  config ACPI
>       bool
> -     prompt "ACPI (Advanced Configuration and Power Interface) Support" if 
> EXPERT = "y"
> +     prompt "ACPI (Advanced Configuration and Power Interface) Support" if 
> EXPERT
>       depends on ARM_64
>       ---help---
>  
> @@ -51,7 +51,7 @@ config GICV3
>  
>  config HAS_ITS
>          bool
> -        prompt "GICv3 ITS MSI controller support" if EXPERT = "y"
> +        prompt "GICv3 ITS MSI controller support" if EXPERT
>          depends on GICV3 && !NEW_VGIC

Could I talk you info switching ones like the above (looks like
there aren't further ones) to ...

> @@ -81,7 +81,7 @@ config SBSA_VUART_CONSOLE
>         SBSA Generic UART implements a subset of ARM PL011 UART.
>  
>  config ARM_SSBD
> -     bool "Speculative Store Bypass Disable" if EXPERT = "y"
> +     bool "Speculative Store Bypass Disable" if EXPERT

... this more compact form on this occasion?

Jan