RE: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Markus Armbruster <armbru@xxxxxxxxxx>
> Sent: 05 May 2020 11:19
> To: qemu-devel@xxxxxxxxxx
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>; Anthony Perard 
> <anthony.perard@xxxxxxxxxx>; Paul
> Durrant <paul@xxxxxxx>; Gerd Hoffmann <kraxel@xxxxxxxxxx>; 
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add 
> usb-host errors
> 
> usbback_portid_add() leaks the error when qdev_device_add() fails.
> Fix that.  While there, use the error to improve the error message.
> 
> The qemu_opts_from_qdict() similarly leaks on failure.  But any
> failure there is a programming error.  Pass &error_abort.
> 
> Fixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
> Cc: Paul Durrant <paul@xxxxxxx>
> Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>

Acked-by: Paul Durrant <paul@xxxxxxx>