[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
Date: Mon, 18 May 2020 11:23:00 -0600
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
Delivery-date: Mon, 18 May 2020 17:23:48 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Sat, May 16, 2020 at 6:22 AM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> Any error from hvm_save() or hvm_set_param() leaks the c.data allocation.
>
> Spotted by Coverity.
>
> Fixes: 353744830 "x86/hvm: introduce hvm_copy_context_and_params"
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks for the fix, my bad!

Tamas

References:
- [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()
  - From: Andrew Cooper

Prev by Date: Re: [PATCH v3 1/5] x86: suppress XPTI-related TLB flushes when possible
Next by Date: Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0
Previous by thread: Re: [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()
Next by thread: [qemu-mainline test] 150211: regressions - FAIL
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.