[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 22 May 2020 08:41:17 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZ8mvoVssdd5lvUpx+KPlVr59eHE7C91DlklRpTWB9k=; b=UZ9KzEqCaNuuUN5Tn1X6+7ib69UDJh7dNmVVawulAWxCDS8ko8I6GoS/TldbtZGHnxLoAeZc3/NEUCxH9QGI4BUboa5KLHhG9P0l+fOoGLqseyaV3bmNlULx2PBXO5K58DTKubDOYn96cnRlq1PHvA0JhlPIqx27KpZ1L34X7Sl0Ui4atBwc+z+itI8lV9/psj7K3RlOdBQuyDTYfsARNfSU3bLA+uP9HxyUWxShJZXDS6lNDErAUCoUsG6YHwI8QMklBv33iKLtO0+RdbXk6EAWuni8aB5xJAlI5zYS1FmF/Uigrz4v2ZCo8xGhTU6UJs0kBpvpxrbGwVJiN5EM0Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hc4wifgZLMYva5e5BQg2NxUzC4SiNDv9rinzkg57EP0mG1FHpYm2mMkmwwb+X8wE8QNn2FLCyTehGbIYV75ljQTEQ0Yq2KzuJBep1YXQUyvzgXFNT2ID8IXmU8o/TrPB90TvWisOsJy98HWxuMC2kxX6HqmFI1QUIJiM2LmTN1HkCTSFQBadhU1ZQTvwL3argeq+ivbSeoNbeleB/6jpGVoMbhQCEL87VQGiJ0QqTsiklkmrMhAvDhjp2ub5L/2qvb7TVOHSKaOsLRpxGR9M08RZxDCbY8wW9Xq99DWs1GXnLk0w8Ap+wrzsbyXmGKxO6EZAO1TBwJpK7ikgk1DHlw==
  • Authentication-results-original: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 22 May 2020 08:41:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWIr9BT1TmXNUg30iaUVp4td7OCaiz5AWA
  • Thread-topic: [PATCH 2/3] configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS

Hi,

As a consequence of this fix, the following has been committed (I guess as a 
consequence of regenerating the configure scripts):
diff --git a/tools/configure b/tools/configure
index 375430df3f..36596389b8 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4678,6 +4678,10 @@ for ldflag in $APPEND_LIB
 do
     APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
 done
+if  ! -z $EXTRA_PREFIX ; then
+    CPPFLAGS="$CPPFLAGS -I$EXTRA_PREFIX/include"
+    LDFLAGS="$LDFLAGS -L$EXTRA_PREFIX/lib"
+fi
 CPPFLAGS="$PREPEND_CPPFLAGS $CPPFLAGS $APPEND_CPPFLAGS"
 LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPEND_LDFLAGS”

This should be:
if  [ ! -z $EXTRA_PREFIX ]; then

As on other configure scripts.

During configure I have not the following error:
./configure: line 4681: -z: command not found

Which is ignored but is adding -L/lib and -I/include to the CPPFLAGS and LDFLAGS

What should be the procedure to actually fix that (as the problem is coming 
from the configure script regeneration I guess) ? 

Bertrand

> On 5 May 2020, at 10:24, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> 
> The path provided by EXTRA_PREFIX should be added to the search path
> of the configure script, like it's done in Config.mk. Not doing so
> makes the search path for configure differ from the search path used
> by the build.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Please re-run autoconf.sh after applying.
> ---
> m4/set_cflags_ldflags.m4 | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/m4/set_cflags_ldflags.m4 b/m4/set_cflags_ldflags.m4
> index cbad3c10b0..08f5c983cc 100644
> --- a/m4/set_cflags_ldflags.m4
> +++ b/m4/set_cflags_ldflags.m4
> @@ -15,6 +15,10 @@ for ldflag in $APPEND_LIB
> do
>     APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
> done
> +if [ ! -z $EXTRA_PREFIX ]; then
> +    CPPFLAGS="$CPPFLAGS -I$EXTRA_PREFIX/include"
> +    LDFLAGS="$LDFLAGS -L$EXTRA_PREFIX/lib"
> +fi
> CPPFLAGS="$PREPEND_CPPFLAGS $CPPFLAGS $APPEND_CPPFLAGS"
> LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPEND_LDFLAGS"])
> 
> -- 
> 2.26.2
> 
> 


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.