Re: [PATCH for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, May 29, 2020 at 10:15 AM Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 29/05/2020 17:06, Tamas K Lengyel wrote:
> > The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a
> > boolean. This is incorrect and breaks external-only usecases of altp2m that
> > is set with a value of 2.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>
> Urg yes.  Sorry.
>
> However, this doesn't build because there is another use of the altp2m
> variable between the two hunks below, for compatiblity with the older
> altp2mhvm option.

Eh, so much for hastily sending a patch with last minute changes.

>
> I think changing its type just to int out to suffice?

Indeed, that would work as well. Let me just resend with that.

Tamas