[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[OSSTEST PATCH 4/4] cs-bisection-step: Do not needlessly repro on tip



If we were halfway through bisecting, we treat the incident failure as
the basis failure.  But our previous bisection results can count as
indications that things are really failing - we don't need to repro on
the very final commit.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 cs-bisection-step | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cs-bisection-step b/cs-bisection-step
index bc6fb794..9a0fee39 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -873,7 +873,8 @@ sub search () {
         need_repro_sequence(2, sub {
             my ($repro_count, $is_last_repro) = @_;
             need_repro('pass', $nodes{"@basispass_rtuple"}, "basis pass") ||
-            need_repro('fail', $nodes{"@latest_rtuple"},    "basis failure");
+            need_repro('fail', $nodes{"@latest_rtuple"}, "basis failure",
+                      !$is_last_repro);
         });
 
     foreach my $startfail (@failures) {
-- 
2.20.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.