Re: [PATCH v1] tools: fix usage of strncpy

[Rich Persaud <persaur@xxxxxxxxx>]

On Jun 8, 2020, at 10:12, Olaf Hering <olaf@xxxxxxxxx> wrote:
> 
> Am Mon, 8 Jun 2020 08:43:50 -0400
> schrieb Jason Andryuk <jandryuk@xxxxxxxxx>:
> 
>> I added a length check in this patch:
> 
> gcc will not recognize such runtime checks and will (most likely) complain 
> about the strncpy usage anyway, just as it does now in 
> libxl__prepare_sockaddr_un. While the usage in libxl__prepare_sockaddr_un is 
> fatal due to -Werror, libvchan is apparently built without -Werror.
> 
> Olaf

Is there any reason not to take a patch that builds libvchan with -Werror?

Rich