RE: Build fix backports for 4.9 - 4.11 inclusive

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Ian 
> Jackson
> Sent: 10 June 2020 12:12
> To: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; committers@xxxxxxxxxxxxxx; Wei Liu 
> <wl@xxxxxxx>
> Subject: Build fix backports for 4.9 - 4.11 inclusive
> 
> 4.9 to 4.11 don't build on Debian stable, which we are now using in
> osstest.  This is because they are missing a number of compile fixes.
> 
> Where things are straightforward I intend to backport these and push
> them to the relevant Xen stable branches without formally posting
> about them each here.  I hope that is OK.
> 
> 
> So far I have identified:
> 
> For 4.11:
> 
>   2b50cdbc444c637575580dcfa6c9525a84d5cc62
>   tools/xentop : replace use of deprecated vwprintw
> 
> That makes it build.  I will push it shortly.
> 
> 
> For 4.10:
> 
> That and a large number of fixes from Marek Marczykowski-Górecki and
> one from John Thomson.  Additionaly there is a problem with seabios,
> which is missing:
> 
>   8c3f57ea1217ea0c80a72898bc35baa0e14af0e0
>   ssdt: Fix building of legacy acpi tables on current iasl compiler
> 

Something like this is hitting me building 4.11 too. Weirdly it does not hit if 
I do a clean build... only incremental:

make -C seabios-dir all
make[3]: Entering directory 
'/local/scratch/pdurrant/xen/tools/firmware/seabios-dir-remote'
  Compiling IASL src/fw/ssdt-misc.hex
out/src/fw/ssdt-misc.dsl.i      4: DefinitionBlock ("ssdt-misc.aml", "SSDT", 
0x01, "BXPC", "BXSSDTSUSP", 0x1)
Error    6155 -                                                                 
Invalid OEM Table ID ^  (Length cannot exceed 8
characters)

ASL Input:     out/src/fw/ssdt-misc.dsl.i - 102 lines, 2567 bytes, 35 keywords
Listing File:  out/src/fw/ssdt-misc.lst - 8393 bytes
Hex Dump:      out/src/fw/ssdt-misc.hex - 4096 bytes

Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 2 Optimizations

> I think this can probably just be cherry-picked onto upstream seabios
> 10.2.
> 
> Wei, should we do that, or should we try to persuade upstream to make
> a 10.4 containing this fix, or what ?
> 
> I don't yet know if this is a complete list.
> 
> 
> For 4.9 I think probably all of the above.  There is also a build
> failure I don't yet understand:
> 
>   ld: 
> /home/osstest/build.150951.build-amd64/xen/stubdom/mini-os-x86_64-vtpmmgr/mini-os.o:
>   in function `TPM_TakeOwnership': gdtoa-hexnan.c:(.text+0x829a): undefined 
> reference to
> `unpack3_TPM_RSA_KEY_PARMS'
> 
> 
> Thanks,
> Ian.