[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libacpi: Widen TPM detection


  • To: Jason Andryuk <jandryuk@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 11 Jun 2020 12:52:01 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Thu, 11 Jun 2020 11:52:28 +0000
  • Ironport-sdr: dDEC1pmsvKf7uyrBf7jK0HYgkq9fr62btkvQ1EKAdtjvXO20kvRD4/wEfjqGoECBjHg11vLwem v7te6OCNgczEwj6F/4TSbaEKgeebUlRpzIxUguWD2Np5o6J4pNe63CTyyIZNqGyWMSS7OyTWt4 egysWBFwbs9/dVJKi+yIHcr426rL+fZ3HycKMkItWO1DaLOeaXjjvTV+CAcAm6xh4FF7PORiUg 6oKWt0eTfa23Z4dlISJeHZxg6slMD+eHUaiortTdgyWyOShnD4TZvs8/i04mv5tZaU7SB4o7qU RdE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/06/2020 04:55, Jason Andryuk wrote:
> The hardcoded tpm_signature is too restrictive to detect many TPMs.  For
> instance, it doesn't accept a QEMU emulated TPM (VID 0x1014 DID 0x0001).
> Make the TPM detection match that in rombios which accepts a wider
> range.
>
> With this change, the TPM's TCPA ACPI table is generated and the guest
> OS can automatically load the tpm_tis driver.  It also allows seabios to
> detect and use the TPM.  However, seabios skips some TPM initialization
> when running under Xen, so it will not populate any PCRs unless modified
> to run the initialization under Xen.
>
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This looks like it wants backporting, so CC'ing Paul for a 4.14 release ack.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.