Re: [PATCH] x86/boot: use BASEDIR for include path

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/06/2020 12:54, Bertrand Marquis wrote:
> Use $(BASEDIR)/include instead of $(XEN_ROOT)/xen/include for the
> include path to be coherent with the rest of the Makefiles.
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Does something subtle break before this change?

~Andrew

> ---
>  xen/arch/x86/boot/build32.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk
> index 5851ebff5f..8cd5403926 100644
> --- a/xen/arch/x86/boot/build32.mk
> +++ b/xen/arch/x86/boot/build32.mk
> @@ -5,7 +5,7 @@ include $(XEN_ROOT)/Config.mk
>  $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
>  
>  CFLAGS += -Werror -fno-builtin -g0 -msoft-float
> -CFLAGS += -I$(XEN_ROOT)/xen/include
> +CFLAGS += -I$(BASEDIR)/include
>  CFLAGS := $(filter-out -flto,$(CFLAGS)) 
>  
>  # NB. awk invocation is a portable alternative to 'head -n -1'