[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libxl dirty in tree after libxl build


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 12 Jun 2020 15:12:12 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 12 Jun 2020 14:12:29 +0000
  • Ironport-sdr: HuiODcQvIs84RzWq+XzbI4P0f9gcZjjP2aOhlN4/CUkS4m5l0uJvjxbB2WW6YMhFTlcrDltPMQ zwwmg7/PbAACcr1PvqzBdBynTmC68BdJIoeDsiMaw+kKlg3F1Uycsk31H0HxZKwqMGFaFOUXrq gCJX8poqBk94G0PA5oHi0SF6f0bTyCtIUz8OlY4PHxOJqQiX39TAAfvmKUF9301UTcMsfbaX/5 MwBjgD/LnyOvOXiKeXIw9zW7gQ4+hhPdr8zcpLxoUBoMGsWDqzXKTIWytrCVZgUj3bYQs6XT5Q iAc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("libxl dirty in tree after libxl build"):
> A build of libxl has just dirtied the tree with:
> 
> index 05f7ac74a0..94a4438666 100644
> --- a/tools/libxl/libxlu_disk_l.c
> +++ b/tools/libxl/libxlu_disk_l.c
> @@ -10,221 +10,11 @@
>  #define FLEX_SCANNER
>  #define YY_FLEX_MAJOR_VERSION 2
>  #define YY_FLEX_MINOR_VERSION 6
> -#define YY_FLEX_SUBMINOR_VERSION 4
> +#define YY_FLEX_SUBMINOR_VERSION 1
>  #if YY_FLEX_SUBMINOR_VERSION > 0
>  #define FLEX_BETA
>  #endif
> 
> and a whole slew of other changes in the generated code.  It looks like
> the version of Flex has just been updated in Jessie.
> 
> Given the flex and bison are strictly required for the libxl build, why
> is this temporary file checked in?

The point of the exercise is to *not* require them.  The reason is
that some of our developers have very old development systems which do
not support essential flex/bison features.

How about we update them to the version from buster ?

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.