RE: [XEN PATCH for-4.14] tools/xen-ucode: fix error code propagation of microcode load operation

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Paul Durrant writes ("RE: [XEN PATCH for-4.14] tools/xen-ucode: fix error code 
propagation of microcode load operation"):
> > -----Original Message-----
> > From: Ian Jackson <ian.jackson@xxxxxxxxxx>
> > Paul, would you Release-ack a patch that replaced every `return errno'
> > with (say) exit(12) ?
> 
> Why 12?

I tend to use 12 to mean `things went wrong'.  1 is a poor choice for
this because you want to use smaller numbers for less severe errors
and you want some space for things like "everything went OK but the
thing you asked me to delete already didn't exist" or "I compared
these files like you asked, and they are different".

> >  Otherwise, fixing this program not to try to
> > fit errno into an exit status is future work.  Also I notice that the
> > program exits 0 if invoked wrongly.  Unhelpful!  I would want to fix
> > that too.
> 
> Agreed that is unhelpful. I'm happy in principle to release-ack
> something replacing the returns with exits.

Thanks,
Ian.