[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.14] tools: check go compiler version if present
- To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Mon, 15 Jun 2020 11:42:33 +0000
- Accept-language: en-GB, en-US
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>
- Delivery-date: Mon, 15 Jun 2020 11:42:45 +0000
- Ironport-sdr: fYcpnAMj5QakSDLOon9DMnk0cUKJ62zFVtVmeFl15rdfY8uJjciPfeUNFU/+C/9JQKDx3hAlZB NXzDXlpfIHz4w6Lt7m4ajUlBxq3kC1U27xEBGo33kXtngR9ECYTnNz4eJjoFKdLePVieMhzvDh PqXmpLMGcl+YL9LrzkJdoxJ0t4QbA8Z7PucKXRZ5nCNSnlmMsDYz5ntsGAEUezoLUUTXJd8NUQ 0241Z3W4VEGsdus0YLKtogWeQkytNqvA80Rk+xJd4U422FbCHDR7/YWLLr6aCPnCqS1gR8AnXr Huc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWQMYebVnRI4xswUubEbtplwogO6jZcQgA
- Thread-topic: [PATCH for-4.14] tools: check go compiler version if present
> On Jun 12, 2020, at 3:31 PM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>
> Currently, no minimum go compiler version is required by the configure
> scripts. However, the go bindings actually will not build with some
> older versions of go. Add a check for a minimum go version of 1.11.1 in
> accordance with tools/golang/xenlight/go.mod.
>
> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
There’s a good chance I won’t have time to review the code for this at all this
week; but regarding the intention of having 1.11.1 as a minimum version:
Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
|
