[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/9] tests/cpu-policy: Confirm that CPUID serialisation is sorted


  • To: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 15 Jun 2020 16:00:39 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 15 Jun 2020 15:00:50 +0000
  • Ironport-sdr: iA9dAEPWvvElXBYE/r76lYVhY+kVnJeKSeon2KGW2OJeHj/NKvYKsC/FzQKK3qBU9po8shJvyC 1cXV4CAyRTVpaGTOD2M3PXOPcFpHP52Xa7yt2D2YAEeaHsHD8P0RvqiO2Jv8eYrS+Hp/iSogmh UbzYTAplQoTHuFJi1J+p8x8nnSpNdszXjCk5QIQLKGmo62Nn1rFxnRv32QqkhWOLhoOgve0BdX SGaESY5esALFqvImkYmvcyvrX3Y46++Kbra1rCkAfLeapjTxxDKFnPP6AFaxAlFPTS3ApV0gPT YvY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15/06/2020 15:52, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH 2/9] tests/cpu-policy: Confirm that CPUID 
> serialisation is sorted"):
>> The existing x86_cpuid_copy_to_buffer() does produce sorted results, and 
>> we're
>> about to start relying on this.  Extend the unit tests.
>>
>> As test_cpuid_serialise_success() is a fairly limited set of synthetic
>> examples right now, introduce test_cpuid_current() to operate on the full
>> policy for the current CPU.
>>
>> Tweak the fail() macro to allow for simplified control flow.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>
> I don't think anything in our normal dev workflow runs this
> automatically ?  Maybe this would be something for us to think
> about...

Nothing runs it by default, but it is part of my prepush testing for
anything in the relevant area.

We should do something better, but its not totally trivial.  The x86
emulator test for example needs a fairly bleeding edge version of
binutils, given that we routinely add support for bleeding edge
instruction groups.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.