[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 for-4.14] pvcalls: Document correctly and explicitely the padding for all arches





On 16/06/2020 10:36, Jan Beulich wrote:
On 16.06.2020 11:19, Julien Grall wrote:


On 16/06/2020 09:26, Jan Beulich wrote:
On 13.06.2020 20:41, Julien Grall wrote:
@@ -73,10 +76,18 @@ struct xen_pvcalls_request {
               uint32_t flags;
               grant_ref_t ref;
               uint32_t evtchn;
+#ifndef __i386__
+            uint8_t pad[4];
+#endif

Where possible I think uint32_t would be slightly better to use.

OOI, why?

Because everything else here uses the wider type, plus the
question of why use a compound type (array) when a simple
one does.
This is pretty much a matter of taste. In this case, I decided to specify the padding the same way accross all the structure.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.