[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations


  • To: Paul Durrant <xadimgnik@xxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Thu, 18 Jun 2020 16:56:25 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
  • Delivery-date: Thu, 18 Jun 2020 15:56:36 +0000
  • Ironport-sdr: IF2lUxJiCLfeb+NMa0u2nWI+U9T1Cqi5ttIEA/BMekhF9lgo6tP9pa9rXzPWDL/GZrzem8+eW1 la+xNqD1+yRHRz4ygBLIavLDEbFvUBdinfpO5e2RFzTb8WMEza5D0MB9dsMJAZmegf/kxj5SJA 9r/cDXNndrO0T4JpdOMPeqOp6JHYZhOTrv/vpnDmufp9hEo4COGK/4wReZechVaZjZMbjwrEah 0HeqBtDe9QGC/Mqqb6v0Yvd09i5+VqfDuG46zevJrfgiwI+YJiSik3xhejJuVLF4jyIb23wXgq BmI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Samuel Thibault writes ("Re: [PATCH v1] stubdom/vtpm: add extern to function 
declarations"):
> Jason Andryuk, le mer. 17 juin 2020 09:35:52 -0400, a ecrit:
> > On Wed, Jun 17, 2020 at 2:10 AM Olaf Hering <olaf@xxxxxxxxx> wrote:
> > >
> > > Code compiled with gcc10 will not link properly due to multiple 
> > > definition of the same function.
> > >
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > 
> > Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> 
> Acked-by: Samuel Thibault <samuel.thibaut@xxxxxxxxxxxx>

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks.  I have confirmed that these symbols look to be defined (in
tpm/tpm_emulator_extern.c).  So the patch is correct.

I think this is 4.14 material.  Paul ?

We should also consider it for backports.  How far back do we need
to go ?

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.