[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v1 4/6] xentop: collect IRQ and HYP time statistics.


  • To: Julien Grall <julien@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Thu, 18 Jun 2020 20:24:48 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=na25ahuFea09fEF4sXKL6wV565mkcRkDMhGmlR1U5HY=; b=nsi/c8etmavMETBhjOsVfAk31CajvD1AmYegegwhoIsx9V1n6Cp4RPlB2dnPhgIowUM7sG/xZ/uEgpge7Uk9DJWm5Ks5aZQrhWehiwGVwxuUjvejlf82Ymy4zDJrM6ZdlNbukZTpWc70OCCsBC8DFSVwkwz0DBO+csdBDoXzvbHAGgANfnpd1gCfH4u6siiX0TQCJViDP42ZSd20GxOj4mfuNn0RG8SKycCmon3rVU8Yj9Mr3UhD8+hSHvDP4ZPstLICWEKR2gNmeKgFh7/kVoKanvDDUWT87voXMbQtd4keyDzI+UtRFX+C1EbOofgV952SJXEE0Hh7l7vl4WTS+Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DRXjcZREO5np5G9LlJHR4XgjxIPHfVbgc3JktwIpWth+6/c3GThfQZdOS11Bgmu4dRGaJdYrAD/xHrmsU4jTzpIKIgYh35V8GpE1QTEjpYE6otAB2MYoAIdNkRH8p0j22V+dPYiz8t7bgU7herUZEBHemRH/1vIILbckVDHCGbfeNBXZdZF2vv0oP6EcdAKQtBtr5Ti5sd0s1DcMzjUNFMSe5clDK3X7t6debEJ4leMaJKnu4dwKiuAo1htEDn4BJB2HMtoMW4ODoUOITFyv/ZWF8TERlHUGLfDWh/0pQRnc0UWF00BkvztlBFoQQzou8YhhXuv/v7C38cvyMrs0Bg==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com;
  • Cc: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "dfaggioli@xxxxxxxx" <dfaggioli@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 18 Jun 2020 20:25:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWQE+Tib/gTK49mk6bUudd1VvXZqjUa0CAgABx3ACAABDmgIAJ7mUA
  • Thread-topic: [RFC PATCH v1 4/6] xentop: collect IRQ and HYP time statistics.

Hi Julien,

Julien Grall writes:

> Hi Volodymyr,
>
> On 12/06/2020 12:44, Volodymyr Babchuk wrote:
>>
>> On Fri, 2020-06-12 at 06:57 +0200, Jürgen Groß wrote:
>>> On 12.06.20 02:22, Volodymyr Babchuk wrote:
>>>> As scheduler code now collects time spent in IRQ handlers and in
>>>> do_softirq(), we can present those values to userspace tools like
>>>> xentop, so system administrator can see how system behaves.
>>>>
>>>> We are updating counters only in sched_get_time_correction() function
>>>> to minimize number of taken spinlocks. As atomic_t is 32 bit wide, it
>>>> is not enough to store time with nanosecond precision. So we need to
>>>> use 64 bit variables and protect them with spinlock.
>>>>
>>>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>>>> ---
>>>>    xen/common/sched/core.c     | 17 +++++++++++++++++
>>>>    xen/common/sysctl.c         |  1 +
>>>>    xen/include/public/sysctl.h |  4 +++-
>>>>    xen/include/xen/sched.h     |  2 ++
>>>>    4 files changed, 23 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
>>>> index a7294ff5c3..ee6b1d9161 100644
>>>> --- a/xen/common/sched/core.c
>>>> +++ b/xen/common/sched/core.c
>>>> @@ -95,6 +95,10 @@ static struct scheduler __read_mostly ops;
>>>>       static bool scheduler_active;
>>>>    +static DEFINE_SPINLOCK(sched_stat_lock);
>>>> +s_time_t sched_stat_irq_time;
>>>> +s_time_t sched_stat_hyp_time;
>>>> +
>>>>    static void sched_set_affinity(
>>>>        struct sched_unit *unit, const cpumask_t *hard, const cpumask_t 
>>>> *soft);
>>>>    @@ -994,9 +998,22 @@ s_time_t sched_get_time_correction(struct
>>>> sched_unit *u)
>>>>                break;
>>>>        }
>>>>    +    spin_lock_irqsave(&sched_stat_lock, flags);
>>>> +    sched_stat_irq_time += irq;
>>>> +    sched_stat_hyp_time += hyp;
>>>> +    spin_unlock_irqrestore(&sched_stat_lock, flags);
>>>
>>> Please don't use a lock. Just use add_sized() instead which will add
>>> atomically.
>>
>> Looks like arm does not support 64 bit variables. >
>> Julien, I believe, this is armv7 limitation? Should armv8 work with 64-
>> bit atomics?
>
> 64-bit atomics can work on both Armv7 and Armv8 :). It just haven't
> been plumbed yet.
>
> I am happy to write a patch if you need atomic64_t or even a 64-bit
> add_sized().

Looks like I'll need this patch. So, if you still have time, it will be
great, if you'll write it.

-- 
Volodymyr Babchuk at EPAM

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.