[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for 4.14] libxl: allow passthrough to PV guests regardless of whether IOMMU is enabled


  • To: Paul Durrant <paul@xxxxxxx>, Patrik Horník <patrik@xxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 19 Jun 2020 16:25:30 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <pdurrant@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 19 Jun 2020 15:25:39 +0000
  • Ironport-sdr: /mSgulF+ycME8TtcnonrGmCH8Byxg2si0Wz7VVPdJ4wvABsGA4c3np5bWsLHKgbSaP70TioZb+ vGIKqeqOQv0zacONna5UKXgUTMd+7+5/Qez50c8WRW0kpy/63v5RmgfSMm8yZi5Bq4qekBuCnl 7BhW1ev5XzXXwk9cCYDm15ZMiSW1y1kbCMqEPVSqnyf/RitR1M8K4GqCHtpriP2vUT8J2gTW/J zLxP4dyoH7TwYxpAPb1v+XRQBnr3o6ynbxkPfVyZ4nHQMzTZ0TLZ8jAXqVkAatuAW0QyWOImk1 Zc0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Paul Durrant writes ("[PATCH for 4.14] libxl: allow passthrough to PV guests 
regardless of whether IOMMU is enabled"):
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> Commit babde47a "introduce a 'passthrough' configuration option to xl.cfg..."
> added a check to xl_parse.c:parse_config_data() to make sure that an IOMMU
> was present and enabled in the system before allowing devices to be passed
> through to a guest. This check was then subsequently moved into
> libxl_create.c:libxl__domain_config_setdefault() by commit ad011ad0 "libxl/xl:
> Overhaul passthrough setting logic".
> 
> Prior to this check being added, it was possible (although not in any way safe
> or supported) to pass devices through to a PV guest without an IOMMU being
> enabled in the system. This patch relaxes the check for PV guests to restore
> that possibility, emitting a warning instead.

Thanks.

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I think this patch could have
  Reported-by: Patrik Horník <patrik@xxxxxxxxx>
Patrik, if we put your credit in like this it will be permanently
recorded in our git history, as part of our code traceability etc.
Please let us know what you would prefer.

> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>A
> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> This patch ought to be in 4.14 as it as very obvious change, restoring lost
> functionality that has affected a user.

Thanks.  I'll take that as a release-ack :-).

Also, I will add this tag too when I commit this:

Backport: 4.13+

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.