[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC XEN PATCH 22/23] riscv: Add sysctl.c


  • To: Bobby Eshleman <bobbyeshleman@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 22 Jun 2020 13:43:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/SYjeg/ozQ31IKYOJt0B1R7JJDh2aIqKSbtZjFwpt24=; b=fEnuTK+Dje/VBvQueK+0Iquuus4Nwl62vV5+f9ktgLmxFZaX5fE26Avyq5lvrdQLMjED1mQINDRE7hMiaI+q20BKIcpc6TjYTCK6JrAYhjCamxY/4BQWSU26GDhwQcGqEleWYkoDS1uYtGsqprg0/eg4ec43Dyd4x1J6Nii/iC7NI63xHeXt65C8vBF+/L+/YM5GnJ0LWQwpSG0LcXsZ4gFnJBMrb0vdgJOS8R9HbLS5hmrcZdGvFKlLrZuVVoR3meh5Gb67rBMkIE7+zvlzgQpDEKQB+Y+RlYm5hXJdgSuhdXg6mRsPVUfjCiDdG7O5uHo6v1HWakWecDYYAjDRoQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpvFXO74JMXGHYMRjs5mL/g2WH2Sqrl5I7dRyDqT3AXe221Z7P6w0/XQTE1b7N3mB02nBqnmprPrc3yBmK1IJO+5aTd1H25k8z5MyKEyJg/a0eVRN7funCQRyi+Hxk4CXmkf16CdmcIuHnHxywpMB25Cg8eA/Kst8klYEM1yH35osRBCAC5sDy2Tx9RMxx1F/2T66LuxkycD1RqM0QinswC2afonsS79/6MABcScIpQ1WonvBmKhSZALV1MpMXyS1nnBO7re+720gc+yM4BtdumLRTJWWgU05EPUbd2dAgO4EtNmdwyCsMd0DTT+QumCgY4tLfyYk9246DUyX3gHNw==
  • Authentication-results: starlab.io; dkim=none (message not signed) header.d=none;starlab.io; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxxx>, Dan Robertson <dan@xxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 22 Jun 2020 11:43:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.01.2020 02:59, Bobby Eshleman wrote:
> --- /dev/null
> +++ b/xen/arch/riscv/sysctl.c
> @@ -0,0 +1,31 @@
> +/******************************************************************************
> + * Arch-specific sysctl.c
> + *
> + * System management operations. For use by node control stack.
> + *
> + * Copyright (c) 2012, Citrix Systems
> + */
> +
> +#include <xen/types.h>
> +#include <xen/lib.h>
> +#include <xen/errno.h>
> +#include <xen/hypercall.h>
> +#include <public/sysctl.h>
> +
> +void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { }
> +
> +long arch_do_sysctl(struct xen_sysctl *sysctl,
> +                    XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
> +{
> +    return -ENOSYS;

At the example of this (there may be more in this series) - -EOPNOTSUPP
please. Only top level hypercall handlers ought to produce -ENOSYS, for
major hypercall numbers with no handler.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.