[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/displif: Protocol version 2

  • To: Jürgen Groß <jgross@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Thu, 2 Jul 2020 07:59:37 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KLUyh4w4CyzcYYsgSbvvd8BZiFlIfy9mVfPOw6PuCZE=; b=h/HHe90OkBr9GifIykBf2e/J5PHn8nZ5Q0YR/ZaJVAhhoR9SWh2x0o7poC+tGNJJD8d7L/4QXor7IUZw5JY9mJqXv6G3F7B3920w4X0FElcI3bBVyGaUfAl4vtG9SsNhQQHJoUuIsnAIknR+GluXPFLARLjjH9Cfzzwi6U2AmLI13FIIO0UKqNrFGW/STYhn4ZYSBIvM1KHU9wg0BSiyH4DWVa++OfkmnJ2ZSIJQOKeKgTaVWDDLMC+z8qp52XwaO8Hqo6NtiIRum4+6JndPj11OncRT90MoMk4tsYGjZLQMxXBS/b200LK8Hh3QZNe8CETgtAJn++zO5sPYjU1YaQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bL9XpOzg3ZpQEJqNdGKNTdlSlmL/+MzTMCNfMlGOBkwValhfYEDylhaIOXdQYkc4Y/TKgf7PZlYAVkIcgozHfk58zVs2Fcz90iD7+Ko3UunRHavwQYWh7sQkTM0W9/qIwSlPNCQiHVVEbogaatdCKWyFaqARVmLsbZCKIICZKatf6rqaKrTyDBF6xbjyHw97AoqzHo3SkJ+dCWlitsUkuldcfW2bLwPwZNrWiC4ckEyihVjwt2AFAi6cnXWjUzAOYmPL6H15E20OT6OzeBBJlJNju3zfMtT25iwezt0YecIFkwhGGgjsLRu00uEHi0f0DZTajvEXA8abtr10Zil8eg==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Delivery-date: Thu, 02 Jul 2020 07:59:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWT3f2pfc1d0tAak69A/eTMH1j5qjyit6AgAAWp4CAAUH0AIAACwsA
  • Thread-topic: [PATCH v2] xen/displif: Protocol version 2

On 7/2/20 10:20 AM, Jürgen Groß wrote:
> On 01.07.20 14:07, Oleksandr Andrushchenko wrote:
>> On 7/1/20 1:46 PM, Jürgen Groß wrote:
>>> On 01.07.20 09:19, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>> 1. Add protocol version as an integer
>>>> Version string, which is in fact an integer, is hard to handle in the
>>>> code that supports different protocol versions. To simplify that
>>>> also add the version as an integer.
>>>> 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
>>>> There are cases when display data buffer is created with non-zero
>>>> offset to the data start. Handle such cases and provide that offset
>>>> while creating a display buffer.
>>>> 3. Add XENDISPL_OP_GET_EDID command
>>>> Add an optional request for reading Extended Display Identification
>>>> Data (EDID) structure which allows better configuration of the
>>>> display connectors over the configuration set in XenStore.
>>>> With this change connectors may have multiple resolutions defined
>>>> with respect to detailed timing definitions and additional properties
>>>> normally provided by displays.
>>>> If this request is not supported by the backend then visible area
>>>> is defined by the relevant XenStore's "resolution" property.
>>>> If backend provides extended display identification data (EDID) with
>>>> XENDISPL_OP_GET_EDID request then EDID values must take precedence
>>>> over the resolutions defined in XenStore.
>>>> 4. Bump protocol version to 2.
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>> Thank you, do you want me to prepare the same for the kernel so
>> you have it at hand when the time comes?
> It should be added to the kernel only when really needed (i.e. a user of
> the new functionality is showing up).

We have a patch for that which adds EDID to the existing PV DRM frontend,

so while upstreaming those changes I will also include changes to the protocol

in the kernel series: for that we need the header in Xen tree first, right?

> Juergen

Thank you,




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.