[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 09/11] x86/domctl: add XEN_DOMCTL_vmtrace_op
- To: Michał Leszczyński <michal.leszczynski@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Mon, 6 Jul 2020 11:31:30 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, luwei.kang@xxxxxxxxx, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, tamas.lengyel@xxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 06 Jul 2020 10:31:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On 05/07/2020 19:55, Michał Leszczyński wrote:
+/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */
+#if defined(__XEN__) || defined(__XEN_TOOLS__)
+
+struct xen_domctl_vmtrace_op {
+ /* IN variable */
+ uint32_t cmd;
+/* Enable/disable external vmtrace for given domain */
+#define XEN_DOMCTL_vmtrace_pt_enable 1
+#define XEN_DOMCTL_vmtrace_pt_disable 2
+#define XEN_DOMCTL_vmtrace_pt_get_offset 3
+ domid_t domain;
AFAICT, there is a 16-bit implicit padding here and ...
+ uint32_t vcpu;
... a 32-bit implicit padding here. I would suggest to make
the two explicit.
We possibly want to check they are also always zero.
Cheers,
--
Julien Grall
|
