[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/mtrr: Drop workaround for old 32bit CPUs


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 8 Jul 2020 13:16:47 +0200
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Wed, 08 Jul 2020 11:17:07 +0000
  • Ironport-sdr: Y7LAl79xRXjtB7ODpVYEuFtpRq1EBz2Li8v/eqx7wuPkp9H/OOtOUb9ODvKCSfb56Rbbvjp1TI SYpncIND7tvjagbcxtS9kxWDNjkpocNgNptfJ1FQn2hHIp+XgQopyq6xZliXvCxgi5sVFC29LH T7BvnFerjdObrIAJPZpvGBHCgkJcHFt/RN1PzlFPjYdCRrpw8RrHlAr3447wrndc72Z5IwdkcQ 1armTpImHl5yBv7+qL4sDzmPGzqd+etoFktYkt0R3XfXMOP7dCFj+SxM0dlYw3gjY73FH36yyl rmY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jul 08, 2020 at 11:52:57AM +0100, Andrew Cooper wrote:
> On 08/07/2020 11:48, Roger Pau Monné wrote:
> > On Wed, Jul 08, 2020 at 11:14:43AM +0100, Andrew Cooper wrote:
> >>    /*  Check upper bits of base and last are equal and lower bits are 0
> >>        for base and 1 for last  */
> >>    last = base + size - 1;
> > FWIW, you could also initialize last at definition time.
> 
> I've got some very different cleanup in mind for that code, seeing as it
> can be simplified to a single test expression.

Oh, I certainly didn't look at it that much :).

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.