[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] docs: specify stability of hypfs path documentation


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Wed, 15 Jul 2020 14:37:11 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 15 Jul 2020 14:37:29 +0000
  • Ironport-sdr: ViQlBA6jt7rRCfn0fjTA5aMpL9bZBBDPr94kQYM+SOs9DiXNKJ+KZs7t1bxYSMtJh0Xaj8IOK1 yEwFN/WCgLIbeAAm7fyC4M9FDMI7Ket2HKX/O5I/l/JZx9dj2YWxeoSEW8HOVsa5vqrmByTKFk 3LanK4Jwgnw5K9kdYvMLuPbG16xbKGgQweQYYR+uSCGSMK5RNzeLMtPSXRl5+DL38481ZCX/sW ThmIZenkgsbQVnwLdI5zL4Lrdht4lu+mzzngBx0rvh0m4gvWhcoB6eArA4tZ5B8A/cj/C6tG6u 3Mo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWWR59fvtpmEuro06JsoMrFTmX86kFdV+AgAMhtYA=
  • Thread-topic: [PATCH v2] docs: specify stability of hypfs path documentation


> On Jul 13, 2020, at 3:47 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
> On 13.07.2020 16:03, Juergen Gross wrote:
>> In docs/misc/hypfs-paths.pandoc the supported paths in the hypervisor
>> file system are specified. Make it more clear that path availability
>> might change, e.g. due to scope widening or narrowing (e.g. being
>> limited to a specific architecture).
>> 
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> Release-acked-by: Paul Durrant <paul@xxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> However, I'd like agreement by at least one other REST maintainer on
> ...
> 
>> @@ -55,6 +58,11 @@ tags enclosed in square brackets.
>> * CONFIG_* -- Path is valid only in case the hypervisor was built with
>>   the respective config option.
>> 
>> +In case a tag for a path indicates that this path is available in some
>> +case only, this availability might be extended or reduced in future by
>> +modification or removal of the tag. A path once assigned meaning won't go
>> +away altogether or change its meaning, though.
> 
> ... the newly imposed guarantee we're now making. We really want to
> avoid declaring something as stable without being quite certain we
> can keep it stable.

The declaration of new nodes must all happen in this file, right?  So as long 
as the maintainer(s) fo this file are aware of that, and it’s commented so that 
people know that expecation, I think it’s OK.

But I think this paragraph isn’t very clear to me what “might be extended or 
reduced …but won’t go away altogether”.

IT sounds like you’re saying:

1. Paths listed without conditions will always be available

2. Paths listed with conditions may be extended: i.e., a node currently listed 
as PV might also become available for HVM guests

3. Paths listed with conditions might have those conditions reduced, but will 
never entirely disappear.  So something currently listed as PV might be reduced 
to CONFIG_HAS_FOO, but won’t be completely removed.

Is that what you meant?

 -George

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.