Re: [PATCH 1/2] Partially revert "Cross-compilation fixes."

[Christian Lindig <christian.lindig@xxxxxxxxxx>]

________________________________________
From: Elliott Mitchell <ehem+xen@xxxxxxx>
Sent: 18 July 2020 04:31
To: xen-devel@xxxxxxxxxxxxx
Cc: Ian Jackson; wl@xxxxxxx; Christian Lindig; dave@xxxxxxxxxx
Subject: [PATCH 1/2] Partially revert "Cross-compilation fixes."

This partially reverts commit 16504669c5cbb8b195d20412aadc838da5c428f7.

Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
---
Doesn't look like much of 16504669c5cbb8b195d20412aadc838da5c428f7
actually remains due to passage of time.

Of the 3, both Python and pygrub appear to mostly be building just fine
cross-compiling.  The OCAML portion is being troublesome, this is going
to cause bug reports elsewhere soon.  The OCAML portion though can
already be disabled by setting OCAML_TOOLS=n and shouldn't have this
extra form of disabling.
---
 tools/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 7b1f6c4d28..930a533724 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -40,12 +40,9 @@ SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
 SUBDIRS-$(CONFIG_X86) += debugger/kdd
 SUBDIRS-$(CONFIG_TESTS) += tests

-# These don't cross-compile
-ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
 SUBDIRS-y += python
 SUBDIRS-y += pygrub
 SUBDIRS-$(OCAML_TOOLS) += ocaml
-endif

 ifeq ($(CONFIG_RUMP),y)
 SUBDIRS-y := libs libxc xenstore
--
2.20.1

-- 
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>