[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.14] golang/xenlight: fix code generation for python 2.6

  • To: <paul@xxxxxxx>, 'Nick Rosbrook' <rosbrookn@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 21 Jul 2020 10:20:36 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: 'Nick Rosbrook' <rosbrookn@xxxxxxxxxxxx>, 'Ian Jackson' <ian.jackson@xxxxxxxxxxxxx>, 'George Dunlap' <george.dunlap@xxxxxxxxxx>, 'Wei Liu' <wl@xxxxxxx>
  • Delivery-date: Tue, 21 Jul 2020 09:21:06 +0000
  • Ironport-sdr: EIFYKv/CbPa0FveuWYks6Mxcspe/ZgyvW95ZOrgEXJzpNl9EXMwgk6BEc9SFlPrAkfsCeYnYMW k7maOgHqpVtdHtqp2IOBOIa43JK8mb0vd9COyxJuBIcdB/dowGiPZ5ncHx4uXnDoYbwRM6I+bH JAOOfr/yhb/bjFDVcnV1vlU8qADA4BOFryHf+tvzFMVsfrYmT2O5QPfE+Lo/e6LFRtDf3hIGKF ETRqeiFxLDNENGWdJG/61ge2akYxxXF8TTSrffsdVqqFHKyTC7+pp6lNc9OUyKXLSQUHwXqUvR +Ac=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21/07/2020 08:13, Paul Durrant wrote:
>> -----Original Message-----
>> From: Nick Rosbrook <rosbrookn@xxxxxxxxx>
>> Sent: 21 July 2020 00:55
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: paul@xxxxxxx; Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>; George Dunlap 
>> <george.dunlap@xxxxxxxxxx>;
>> Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>
>> Subject: [PATCH for-4.14] golang/xenlight: fix code generation for python 2.6
>> Before python 2.7, str.format() calls required that the format fields
>> were explicitly enumerated, e.g.:
>>   '{0} {1}'.format(foo, bar)
>>   vs.
>>   '{} {}'.format(foo, bar)
>> Currently, gengotypes.py uses the latter pattern everywhere, which means
>> the Go bindings do not build on python 2.6. Use the 2.6 syntax for
>> format() in order to support python 2.6 for now.
>> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
> I'm afraid this is too late for 4.14 now. We are in hard freeze, so only 
> minor docs changes or critical bug fixes are being taken at
> this point.

This is Reported-by me, and breaking gitlab CI on the master and 4.14
branches (because apparently noone else cares to look at the results...)

The alternative is to pull support for CentOS 6 from the 4.14 release,
which would best be done by a commit taking out the C6 containers from CI.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.