Re: [PATCH 1/2] Partially revert "Cross-compilation fixes."

[Wei Liu <wl@xxxxxxx>]

On Tue, Jul 21, 2020 at 07:44:10AM -0700, Elliott Mitchell wrote:
> On Tue, Jul 21, 2020 at 12:26:45PM +0000, Wei Liu wrote:
> > On Fri, Jul 17, 2020 at 08:31:21PM -0700, Elliott Mitchell wrote:
> > > This partially reverts commit 16504669c5cbb8b195d20412aadc838da5c428f7.
> > 
> > Ok, so this commit is really old.
> 
> Yup.  It will still be visible in `git blame tools/examples/Makefile`,
> but everywhere else has had commits stacked on top.
> 
> > > Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
> > > ---
> > > Doesn't look like much of 16504669c5cbb8b195d20412aadc838da5c428f7
> > > actually remains due to passage of time.
> > > 
> > > Of the 3, both Python and pygrub appear to mostly be building just fine
> > > cross-compiling.  The OCAML portion is being troublesome, this is going
> > > to cause bug reports elsewhere soon.  The OCAML portion though can
> > > already be disabled by setting OCAML_TOOLS=n and shouldn't have this
> > > extra form of disabling.
> > 
> > The reasoning here is fine by me. And it should be part of the commit
> > message.
> > 
> > I would like to also add "tools: prefix to the subject line:
> > 
> >   tools: Partially revert "Cross-compilation fixes."
> > 
> > If you agree with these changes, no action is required from you. I can
> > handle everything while committing.
> 
> Fine by me.

Your two patches have been applied to staging. Thanks.

Wei.