[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/8] x86: compat header generation and checking adjustments

On 23.07.20 17:45, Jan Beulich wrote:
As was pointed out by 0e2e54966af5 ("mm: fix public declaration of
struct xen_mem_acquire_resource"), we're not currently handling structs
correctly that have uint64_aligned_t fields. Patch 2 demonstrates that
there was also an issue with XEN_GUEST_HANDLE_64().

1: x86: fix compat header generation
2: x86/mce: add compat struct checking for XEN_MC_inject_v2
3: x86/mce: bring hypercall subop compat checking in sync again
4: x86/dmop: add compat struct checking for 
5: evtchn: add compat struct checking for newer sub-ops
6: x86: generalize padding field handling
7: flask: drop dead compat translation code
8: x86: only generate compat headers actually needed

v3: Build fix for old gcc in patch 1. New patch 5.

Just an idea:

Instead of parsing an existing header and trying to create a compat
header from it, assuming some special constructs and names, wouldn't it
make more sense to have a common input file and create non-compat and
compat headers (and the functions/macros to convert them into each
other) from it? This would at once drop the need for compat checking
and new interfaces could be tested automatically to not require a compat




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.