[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] iommu: remove iommu_lookup_page() and the lookup_page() method...

  • To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 24 Jul 2020 19:38:43 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Fri, 24 Jul 2020 18:38:55 +0000
  • Ironport-sdr: 469q0NSn0Eu98I/dW2JBXyLmvtMHRolRQzuWQZhbHzrB9Q8xLtF2kQ3iR0tSdf+Prhz4iGonyX VIIxOnt604Heggj9CKOH4NF08eCv+Jh2htHVgWGX3LPLHKIOkA7JJBg4mDzCDu1OTC2OnqdVUc WNdoRgXKVZjKoG/icQzHm1X0Q2iHxRKM+K9fZFU4aZWY7Adk9rs8ocVhzcFlhJJUgM26bEZumV op2zehAkJnLkSIBfB/G4+cMOCoT3YjMAJMV86/20p1eJcecfJ80mUXXaHhE9Yi7ungKmWX/Nmy jkQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24/07/2020 17:46, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> ... from iommu_ops.
> This patch is essentially a reversion of dd93d54f "vtd: add lookup_page method
> to iommu_ops". The code was intended to be used by a patch that has long-
> since been abandoned. Therefore it is dead code and can be removed.

And by this, you mean the work that you only partial unstreamed, with
the remainder of the feature still very much in use by XenServer?

Please don't go breaking in-use things, simply because we're fixing
Xen's IOMMU mess once large XSA at a time...

As far as I can tell, this patch doesn't interact with any others in the




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.