[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/6] iommu: stop calling IOMMU page tables 'p2m tables'


  • To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 24 Jul 2020 20:08:51 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Fri, 24 Jul 2020 19:09:01 +0000
  • Ironport-sdr: G3N7AlhAc81cS/Q9iEDUhqxMnV1QBOYHf8RzEmgcTnjRWgNEKZxUx4U2hPDg066V2lzN6fX6qZ C+9RZRyd8gGdRqxOK+FzIlAROqBnLpvkyiHl49iLAs6hMlkMIwi8xj0K++HKy8X1gwaFI7p3hS kx17EbbajiMsMvHVk7FR4NbbFTwbH+eniPU3RkCEFEtAJH2DFbCjKJ2Km32n38Y2zO3/djQmOx 82IzmhbIvDIAu9liFecI1x5lzvAJBFoP6rArMbQsikPaq7LrKAyo8hyslQELfbGTNqanW0W5LS GKM=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24/07/2020 17:46, Paul Durrant wrote:
> diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> index 6a3803ff2c..5bc190bf98 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -535,12 +535,12 @@ static void iommu_dump_p2m_table(unsigned char key)
>  
>          if ( iommu_use_hap_pt(d) )
>          {
> -            printk("\ndomain%d IOMMU p2m table shared with MMU: \n", 
> d->domain_id);
> +            printk("%pd: IOMMU page tables shared with MMU\n", d);

Change MMU to CPU?  MMU is very ambiguous in this context.

>              continue;
>          }
>  
> -        printk("\ndomain%d IOMMU p2m table: \n", d->domain_id);
> -        ops->dump_p2m_table(d);
> +        printk("%pd: IOMMU page tables: \n", d);

Drop the trailing whitespace?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.