[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] x86: fold indirect_thunk_asm.h into asm-defns.h

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 27 Jul 2020 17:16:30 +0200
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Mon, 27 Jul 2020 15:16:45 +0000
  • Ironport-sdr: HTb+sqVtINoCdeeUBznbMtFR82HwkjLAIsfU5vtGkArlRP6rMMhwA1YFoYxW6DUHSioQ5dtwi+ jJ5LR+9o2HJ9hsxvdIv30l3Tzro+Fr41lmEQLOhG4Llf7VymmvGNm4bnLwPCCAHtvmSfUZgeoQ bTZ5Go1fiokDFdf9piqfYxBe7kdX3ta1gSELVbToNe0OAWugQ8ByokLsueKVYCh3irIUUxMpbR kmVn8BnC7N03jEfBJ1g/UiGm22wWA6O8jodL4d5vGoS+uc/+CogwWbkUnE+r0PNdy/sAZpiWqy 5ek=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jul 15, 2020 at 12:49:40PM +0200, Jan Beulich wrote:
> There's little point in having two separate headers both getting
> included by asm_defns.h. This in particular reduces the number of
> instances of guarding asm(".include ...") suitably in such dual use
> headers.
> No change to generated code.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Some testing with clang might be required, as with the other patch.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.