[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Mon, 27 Jul 2020 15:29:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gh+GZNaeqoxrikv21vTVFcnARyS7tqp7e4GjswCzLT8=; b=Zebc6RKo0HKDdteCLmJShfiBmYkNswEdq7tVOrnWJ28g5Wl/xnHfl3BotM25gGyhSw3ajhj9qO6RRQ0erLVcOKrXKts3qwta0ipsMxnazlZJqSqhF5jRIJBOPHncg0auMfIzBnoaX4ZPxJ5kut7zRo6QahftNdmAxwLJE9aohKpgZgugQM+kvW4851FUUg0EmWP5brXr0l6Osj7p2/eBIewzM+Gx2o20Rrlh5gW4uGGLCh8kfFejOWMeJp7ASchmV9DLhI7SFvVf9poTBbBbAo0lggHGI776k7DXwr98HYYc4Mxsbj3/fnd6ZCTsgj+qJCmk50GdUR2se9ny04IljQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eN5VA8AdJ09hS8KsXMR8ugUtUC3Eu0NVNDDKfwXEVdno8bv6YaS5WLaAkYAvzUg7+EJderxvzhlrjk7oGgak1YZB2qAwS/OTbquh3CJVCrM9vtbEBW+bqV6xDBJpbiy47YbgP7TrFkDdxLHKxEtAhhh50lyEBarTyx30phbmRX8sEclXK1CePUbKXOPmvpv/Th63ANADA6jbU7wA3TZEAJsxZLm7W0wruygti0LMxw5JaYoUI/s3NrDxtGXFczNd+8TGYoBP6NSU0dtuvPdMXuk4wLUw1xIGG63hTGegjUFQx5Jt+2MImRtQ9sX6Ny+9OAPRLQJqXR37OIx1AN8omQ==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Mon, 27 Jul 2020 15:29:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWYPbO0TX+B10vbkuLRSjkBERSxqkWZWGAgAUt/4A=
- Thread-topic: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.
> On 24 Jul 2020, at 9:23 am, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Rahul,
>
> On 23/07/2020 16:40, Rahul Singh wrote:
>> XEN during boot will read the PCI device tree node “reg” property
>> and will map the PCI config space to the XEN memory.
>> XEN will read the “linux, pci-domain” property from the device tree
>> node and configure the host bridge segment number accordingly.
>> As of now "pci-host-ecam-generic" compatible board is supported.
>> Change-Id: If32f7748b7dc89dd37114dc502943222a2a36c49
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> ---
>> xen/arch/arm/Kconfig | 7 +
>> xen/arch/arm/Makefile | 1 +
>> xen/arch/arm/pci/Makefile | 4 +
>> xen/arch/arm/pci/pci-access.c | 101 ++++++++++++++
>> xen/arch/arm/pci/pci-host-common.c | 198 ++++++++++++++++++++++++++++
>> xen/arch/arm/pci/pci-host-generic.c | 131 ++++++++++++++++++
>> xen/arch/arm/pci/pci.c | 112 ++++++++++++++++
>> xen/arch/arm/setup.c | 2 +
>> xen/include/asm-arm/device.h | 7 +-
>> xen/include/asm-arm/pci.h | 97 +++++++++++++-
>> 10 files changed, 654 insertions(+), 6 deletions(-)
>
> As a general comment, I would suggest to split the patch in smaller chunk.
> This would help the review and also allow to provide more explanation on what
> is done.
Ok I will split the patches in next version of the patch series.
>
> For instance, I think it is possible to a split looking like:
> - Add framework to access an hostbridge
> - Add support for ECAM
> - Add code to initialize the PCI subsystem
>
> There is also some small fixes in this code that probably can move in there
> own patches.
Ack.
>
> Cheers,
>
> --
> Julien Grall
|
