[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"

  • To: Julien Grall <julien@xxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Tue, 28 Jul 2020 10:12:06 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
  • Delivery-date: Tue, 28 Jul 2020 10:12:14 +0000
  • Ironport-sdr: 9I0ZK56lX5DAzvZBQ8nzAh1NdX72NXPvnCcCoMj/FW6k3qYdDzLEF6Khr4an8wlkPhXKBueraU 1WivZlftNwz9V0F9fGl9PW9NwKXbgoXNoZihQeAH/Bx/7ME/Lp42J8+MfJaq7/nEPvaFi2t4N+ R1gMWQfv59G6GIeyLvge4MjQIVrazi7nL6OujHP0oZ5Qve1zgdw6yhtq3pHSUmjzz9oFxhKndH I/fIOMPmU3lCch/ia1eYEgHvhdSH0OXhirHiPXhP/drLVh9xcgmWcRyv0mTzvjMS5eodVXDCOm H54=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWZC+x8Lr8eJ8LdEOQDs5vOcX3hKkcpTEA
  • Thread-topic: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"

> On Jul 27, 2020, at 5:04 PM, Julien Grall <julien@xxxxxxx> wrote:
> Hmmm I forgot to CC George. Sorry for that.
> On 27/07/2020 17:04, Julien Grall wrote:
>> From: Julien Grall <jgrall@xxxxxxxxxx>
>> The operator + will just concatenate two strings. As the result, the
>> configure cmdline for "xentools" will look like:
>> ./configure --disable-stubdom 
>> --disable-qemu-traditional--with-system-qemu=/bin/false 
>> --with-system-seabios=/bin/false--disable-ovmf
>> This can be avoided by explicitely adding the spaces.
>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Oops — thanks.

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.