[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 28 Jul 2020 14:59:08 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 28 Jul 2020 13:59:33 +0000
  • Ironport-sdr: EKu8ZImCF3nFbwNS64XopW8AVXuVnC+aBrx8EODBWfsnZeqQ6rmWePstkU8Mq5A4+2lGWXnR/v /5E4dZDquyd19hoLD2wwXUdl510KA48SXGBemrIGhFnuO4OYAmJwZ+CTxTlm8yJsspKfluaOTS I/m+FlUosxMtagHL4k19OlDfY5W3EjoD0kONvGOHS5vVugmAT1iwK6d6TP4VKzpyT7P+ViDML5 A9avXKv7Fd5llHcxMaEath0t8hXf/2Q3xhfXArPk1v8JO2/kTkf1EYUBPFWbEMgIfBCOPgC3ge F2Y=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/07/2020 20:47, Jan Beulich wrote:
> On 27.07.2020 16:55, Roger Pau Monné wrote:
>> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote:
>>> --- /dev/null
>>> +++ b/xen/include/asm-x86/asm-defns.h
>> Maybe this could be asm-insn.h or a different name? I find it
>> confusing to have asm-defns.h and an asm_defs.h.
> While indeed I anticipated a reply to this effect, I don't consider
> asm-insn.h or asm-macros.h suitable: We don't want to limit this
> header to a more narrow purpose than "all sorts of definition", I
> don't think. Hence I chose that name despite its similarity to the
> C header's one.

Roger is correct.  Having asm-defns.h and asm_defs.h is too confusing,
and there is already too much behind the scenes magic here.

What is the anticipated end result, file wise, because that might
highlight a better way forward.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.