[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] xen/memory: Introduce CONFIG_ARCH_ACQUIRE_RESOURCE

On 30/07/2020 18:28, Andrew Cooper wrote:
On 30/07/2020 10:50, Julien Grall wrote:
Hi Andrew,

On 28/07/2020 12:37, Andrew Cooper wrote:
New architectures shouldn't be forced to implement no-op stubs for

Introduce CONFIG_ARCH_ACQUIRE_RESOURCE which can be opted in to, and
compatibility logic in xen/mm.h

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

With one question below:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>


diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 1061765bcd..1b2c1f6b32 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -685,4 +685,13 @@ static inline void put_page_alloc_ref(struct
page_info *page)
+static inline int arch_acquire_resource(
+    struct domain *d, unsigned int type, unsigned int id, unsigned
long frame,
+    unsigned int nr_frames, xen_pfn_t mfn_list[])

Any reason to change the way we indent the arguments?

So its not all squashed on the right hand side.

Fair enough. I have asked the same question on a follow-up patch. Feel free to ignore it :).


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.