[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain
- To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>
- From: "Dey, Megha" <megha.dey@xxxxxxxxx>
- Date: Tue, 11 Aug 2020 11:46:10 -0700
- Cc: "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "rafael@xxxxxxxxxx" <rafael@xxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "Kumar, Sanjay K" <sanjay.k.kumar@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "Hansen, Dave" <dave.hansen@xxxxxxxxx>, "kwankhede@xxxxxxxxxx" <kwankhede@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "Liu, Yi L" <yi.l.liu@xxxxxxxxx>, "Jiang, Dave" <dave.jiang@xxxxxxxxx>, "Raj, Ashok" <ashok.raj@xxxxxxxxx>, "netanelg@xxxxxxxxxxxx" <netanelg@xxxxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, "Lin, Jing" <jing.lin@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "Ortiz, Samuel" <samuel.ortiz@xxxxxxxxx>, "yan.y.zhao@xxxxxxxxxxxxxxx" <yan.y.zhao@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, "shahafs@xxxxxxxxxxxx" <shahafs@xxxxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "parav@xxxxxxxxxxxx" <parav@xxxxxxxxxxxx>, "eric.auger@xxxxxxxxxx" <eric.auger@xxxxxxxxxx>, "alex.williamson@xxxxxxxxxx" <alex.williamson@xxxxxxxxxx>, "bhelgaas@xxxxxxxxxx" <bhelgaas@xxxxxxxxxx>, "Williams, Dan J" <dan.j.williams@xxxxxxxxx>, "Lu, Baolu" <baolu.lu@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Luck, Tony" <tony.luck@xxxxxxxxx>, "Hossain, Mona" <mona.hossain@xxxxxxxxx>, "vkoul@xxxxxxxxxx" <vkoul@xxxxxxxxxx>, "Pan, Jacob jun" <jacob.jun.pan@xxxxxxxxx>, "dmaengine@xxxxxxxxxxxxxxx" <dmaengine@xxxxxxxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>
- Delivery-date: Wed, 12 Aug 2020 04:11:04 +0000
- Ironport-sdr: anMB1Y/+kAq5EeelEG5REw7u/Wgj16OIMWVVyADcvqBSOlqf3ozdGYQf1MPaBGMxGSh4sbM1o4 7HeBAGS/XcXQ==
- Ironport-sdr: 5aAcR8S72zxamrk1GkqcpkTcLHD6X+V0Qd8VhcPMwxe6NQm/ajJO1T7QBs6tN6/S8h9BEKMK9n htpZpANtoRxw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Thomas,
On 8/11/2020 2:53 AM, Thomas Gleixner wrote:
Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
CC+: XEN folks
Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
The infrastructure itself is not more than a thin wrapper around the
existing msi domain infrastructure and might even share code with
platform-msi.
And the annoying fact that you need XEN support which opens another can
of worms...
hmm I am not sure why we need Xen support... are you referring to idxd
using xen?
which needs some real cleanup first.
x86 still does not associate the irq domain to devices at device
discovery time, i.e. the device::msi_domain pointer is never populated.
So to support this new fangled device MSI stuff we'd need yet more
x86/xen specific arch_*msi_irqs() indirection and hackery, which is not
going to happen.
The right thing to do is to convert XEN MSI support over to proper irq
domains. This allows to populate device::msi_domain which makes a lot of
things simpler and also more consistent.
do you think this cleanup is to be a precursor to my patches? I could
look into it but I am not familiar with the background of Xen
and this stuff. Can you please provide further guidance on where to look?
Thanks,
tglx
|
