Re: [PATCH II v2 01/17] stubdom: add correct dependencies for Xen libraries

[Jürgen Groß <jgross@xxxxxxxx>]

On 17.08.20 12:12, Samuel Thibault wrote:
> Hello,
>
> Juergen Gross, le lun. 17 août 2020 11:49:06 +0200, a ecrit:
> > The stubdom Makefile is missing several dependencies between Xen
> > libraries. Add them.
> > @@ -405,6 +405,7 @@ libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a: 
> > mk-headers-$(XEN_TARGET_ARCH) $
> >   
> >   .PHONY: libxenevtchn
> >   libxenevtchn: libs-$(XEN_TARGET_ARCH)/evtchn/libxenevtchn.a
> > +libs-$(XEN_TARGET_ARCH)/evtchn/libxenevtchn.a: libxentoolcore
> I see
>
> evtchn/Makefile:USELIBS  := toollog toolcore
>
> So it'd actually need libxentoollog as well?
>
> > @@ -423,6 +425,7 @@ libs-$(XEN_TARGET_ARCH)/gnttab/libxengnttab.a: 
> > mk-headers-$(XEN_TARGET_ARCH) $(N
> >   
> >   .PHONY: libxencall
> >   libxencall: libs-$(XEN_TARGET_ARCH)/call/libxencall.a
> > +libs-$(XEN_TARGET_ARCH)/call/libxencall.a: libxentoolcore
> Same with
>
> call/Makefile:USELIBS  := toollog toolcore
>
> ?
>
> > @@ -432,6 +435,7 @@ libs-$(XEN_TARGET_ARCH)/call/libxencall.a: 
> > mk-headers-$(XEN_TARGET_ARCH) $(NEWLI
> >   
> >   .PHONY: libxenforeignmemory
> >   libxenforeignmemory: 
> > libs-$(XEN_TARGET_ARCH)/foreignmemory/libxenforeignmemory.a
> > +libs-$(XEN_TARGET_ARCH)/foreignmemory/libxenforeignmemory.a: libxentoolcore
> Same with
>
> foreignmemory/Makefile:USELIBS  := toollog toolcore
>
> ?
>
> Possibly they are actually already coming from somewhere by
> transitivity, but it'd probably better to just make sure we match
> Makefiles' USELIBS.
Yes. Thanks for catching those.

When all libraries have been switched to the USELIBS scheme I'll add a
patch using those variables in the stubdom Makefile, too. This will
avoid duplicate work when adding new libs or changing dependencies.


Juergen