[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data



On 21.08.20 13:19, Sergei Temerkhanov wrote:
Did you see any specific problem where handler_data is written by
another component?

I've posted this series in the thread
https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00957.html
where the problem is caused exactly by that behavior

In case this is a real problem I don't think your approach will be accepted
Any comments/suggestions are welcome

Not sure if the IRQ maintainers agree with me, but I would add
a set_handler_data and get_handler_data function pointer to
struct irq_chip. If those are set I'd call them for writing/reading
handler_data instead doing it directly. Xen could then specify those
and add a field to its own handler data struct for storing the data
of the driver coming later.

Xen would need another accessor function for its own primary data,
of course.

Adding the IRQ maintainer as he might have an opinion here. :-)


Juergen


Regards,
Sergey

On Fri, Aug 21, 2020 at 1:18 PM Jürgen Groß <jgross@xxxxxxxx> wrote:

On 21.08.20 09:15, Sergey Temerkhanov wrote:
Use a dedicated pointer for IRQ data to avoid conflicts with some
other parts of the kernel code which my use handler_data for their
own purposes while still running on Xen

Sergey Temerkhanov (2):
    Xen: Use a dedicated irq_info structure pointer
    Xen: Rename irq_info structure

   drivers/xen/events/events_2l.c       |  2 +-
   drivers/xen/events/events_base.c     | 80 +++++++++++++---------------
   drivers/xen/events/events_fifo.c     |  5 +-
   drivers/xen/events/events_internal.h | 12 ++---
   include/linux/irq.h                  | 17 ++++++
   kernel/irq/chip.c                    | 14 +++++
   6 files changed, 78 insertions(+), 52 deletions(-)


Did you see any specific problem where handler_data is written by
another component?

In case this is a real problem I don't think your approach will be
accepted, especially the IRQ subsystem maintainers probably won't
like it.

And please include the maintainers of the files you are modifying in
the recipients list of the patch(es).


Juergen





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.