[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 8/8] x86/msr: Drop compatibility #GP handling in guest_{rd,wr}msr()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 31 Aug 2020 17:22:10 +0200
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 31 Aug 2020 15:22:22 +0000
  • Ironport-sdr: yvY5E6LBUMcOvWUguoBTSl+nIx8oQ/rRDbusaQmtptcwfrsFoXYJkMvpkiYk9xj77Ipj+wIXUZ 394VpSrh5Rz/uXub+nhnwFfC6Cj86XRK4kft21qlGnDou8dOUIgGzta6savrhhCljgYsnPI9rX gapXcN3JfkuiPNGt2cH2KeummWT/s+0bC5E8Oe7dglenfjhktgCe3O+TDPQacChMEX+VvWE3N7 N1fMdcFjIAmZXKReula2cRBnnAiJwSH/eFrhcquNIihGsmSyxzCvxJHomsaexxxhkhdaHEiYfl wuw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Aug 28, 2020 at 10:55:29AM +0200, Jan Beulich wrote:
> On 20.08.2020 17:08, Roger Pau Monne wrote:
> > Now that the main PV/HVM MSR handlers raise #GP for all unknown MSRs, there 
> > is
> > no need to special case these MSRs any more.
> 
> I agree, yet I'd like to point out (based on past backporting of
> security fixes) that this change may end up being a good source
> of backporting mistakes, as 4.14 may need chunks added here which
> on master / staging have no place anymore.

Even if we leave this chunk out, patches for > 4.14 won't need to add
anything to make a MSR return a #GP, so it's likely that the chunk
will have to be added for backports anyway.

I really have no idea of how to help with backporting with such change
in place.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.