Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.09.2020 15:02, Roger Pau Monné wrote:
> On Fri, Aug 28, 2020 at 11:51:35AM +0000, Trammell Hudson wrote:
>> --- a/xen/arch/x86/xen.lds.S
>> +++ b/xen/arch/x86/xen.lds.S
>> @@ -156,6 +156,7 @@ SECTIONS
>>         __note_gnu_build_id_end = .;
>>    } :note :text
>>  #elif defined(BUILD_ID_EFI)
>> +  . = ALIGN(32); /* workaround binutils section overlap bug */
> 
> Is this a separate bugfix?
> 
> That's the only change to the linker script, so is this bug somehow
> triggered by the new code additions this commit makes?
> 
> It might also be nice to have some reference to the bug if possible,
> so that we know when the bug has been fixed and thus we can drop the
> workaround.

I think that's to work around a bug I've meanwhile fixed in bfd
(although maybe I should better call it "worked around"). If we
want to include this at all (rather than document that for the
objcopy to work one needs to use a recent tool; the issue doesn't
affect out build system after all, aiui), then I fully agree this
ought to be a separate patch, with a suitable description /
justification.

Jan