Re: [PATCH v4 01/31] tools: generate pkg-config files from make variables

[Wei Liu <wl@xxxxxxx>]

On Mon, Sep 07, 2020 at 04:44:28PM +0200, Jürgen Groß wrote:
> On 07.09.20 16:25, Wei Liu wrote:
> > On Fri, Aug 28, 2020 at 05:07:17PM +0200, Juergen Gross wrote:
> > > For each library built two variants of pkg-config files are created
> > > from a per-library template: an "official" one for installation on
> > > the user's system, and one used for building internal tools, like e.g.
> > > qemu.
> > > 
> > > Instead of the template which is looking very similar for all libraries
> > > generate the pkg-config files directly from make variables.
> > > 
> > > This will reduce the need to specify some pkg-config file entries in
> > > the templates, as the contents can easily be generated from available
> > > data (e.g. "Version:" and "Requires.private:" entries).
> > > 
> > > Especially the variant used for building internal tools needs to gain
> > > additional runtime link parameters for the internally used libraries,
> > > as otherwise those won't be found by the users (e.g. qemu).
> > > 
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > 
> > Do you have the new generated files handy so that I can eyeball them a
> > bit?
> 
> Attached (both, the local and the installed ones, with the complete
> series applied).

Thanks. They look correct to me.

Acked-by: Wei Liu <wl@xxxxxxx>

Wei.