[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm64: fix build with gcc 10
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 8 Sep 2020 13:05:18 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7kcerATzAjpIbNHSWsLQI/C+H0zm4C83hl0owqH8bxo=; b=YrI8SPJiTEEmhq7pxOFOeGpiaWTsOEdfY+p+cggslBlxdFyLTB4M5pA9xcoK/nwK86XNjwqH3B+5t6VXF4zTe8pRQOaXVXrZ3Ro5+Ou8ajzuimnJwKBLeLo8FooceJtB6+DbUeSWoYNGFZ1R/gg66mfCa+uraYi9En6gtQ+CWjNo4gBSNYwD9AjdreiJBgbUiC1K8rnRzqocmdS66CXAlC2k7pUC91TgzZeMXts3Dvzn3cRJmlPsaJqB31i+jv9iJFKmuwY4+Po8ld28Yc+9j7KxghHv6X+XzsvoZINEeDzhFT+majqnFQ4OtL+AJ+Kp1fMfpqaPr2+mKO9AU7zp6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ArIMGV6iEy9VUPr4CxjlAd1lprIkCM0XJL8NB62SGg61ugOS4QfT53nppYnSZ3rc0wz7YuJDgcm5l7a/9rZ6ggY7fVyzyDX8U0r7PSLltzfSBGo6Gp5YGrIiNAORfw4Z8BqsWnnv1uvsMBmd5R57rvtsbGXaumnafwcOEAVVMaJ5bep8JpvUOY6Hb32h5LGONrwRB0wrpVWv7W9zs7xghbRYXRRiZfRFh9AfFZ5lUNXs+ELSFAom2wWD2UTqdQ4kOAXe0sNykXjXQlZRJ/Lst7m8VEmpdIA7doRWR4xWevPRz14heXUVuVep7JZOk2H+Tt/QVZRmgnUHKmF+GlGQSQ==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 08 Sep 2020 13:05:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWhd9Vq9iCRBnsnkuk6dw8UeDDDqletaaA
- Thread-topic: [PATCH] Arm64: fix build with gcc 10
> On 8 Sep 2020, at 13:53, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> With gcc10 inlining is (no longer?) the default for certain atomics.
>
> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/xen/arch/arm/arch.mk
> +++ b/xen/arch/arm/arch.mk
> @@ -12,6 +12,7 @@ CFLAGS-$(CONFIG_ARM_32) += -mcpu=cortex-
>
> CFLAGS-$(CONFIG_ARM_64) += -mcpu=generic
> CFLAGS-$(CONFIG_ARM_64) += -mgeneral-regs-only # No fp registers etc
> +$(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno-outline-atomics)
Why not adding this before with the other “call cc-option” ?
Also it might be a good idea to have a sentence in the commit message with the
error happening when this is not added:
undefined reference to `__aarch64_ldadd4_acq_rel’
Because some might need to backport this to other Xen releases if they switch to
a new compiler (although i could not reproduce that with Xen 4.14).
I tested the patch with Yocto master which is using gcc 10.2 and this works.
Bertrand
>
> ifneq ($(filter command line environment,$(origin CONFIG_EARLY_PRINTK)),)
> $(error You must use 'make menuconfig' to enable/disable early printk now)
>
|
