Re: [PATCH v1] docs: remove bridge-utils from requirements

[Julien Grall <julien@xxxxxxx>]

Hi,

On 09/09/2020 14:17, Olaf Hering wrote:
> Am Wed, 9 Sep 2020 14:06:42 +0100
> schrieb Julien Grall <julien@xxxxxxx>:
>
> > "bridge-utils (if iroute version < ...)"
> A brief search in git://git.kernel.org/pub/scm/network/iproute2/iproute2.git 
> shows bridge support appeared in v3.5.0 from 2012.
>
> One can barely run Xen on such old dists, so the patch is fine as it is.
IMHO, the README is not only here to explain the required softwares for 
the latest distribution. It is also here to explain all the dependencies 
regardless whether Xen can be barely run or not...
At the moment, brctl is still a dependency as hotplug scripts will use 
it if present. In fact, they will *only* fallback to iproute if brctl is 
not present:
    if which brctl >&/dev/null; then
        bridge=$(brctl show | awk 'NR==2{print$1}')
    else
        bridge=$(bridge link | cut -d" " -f7)
    fi

If you think that bridge-utils should be dropped, then please send a 
proposal to remove/deprecate brctl. Until then I think we ought to 
mention the dependency in the README.
Cheers,

--
Julien Grall